-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace react-native-svg with ART #12
Conversation
since react-native ships with it's own vector drawing library, why use an external dependency?
You are genius. But I got some problems when I try to run the Example. AndroidIn order to run on the android, I have to modify the
When I try to run example in the latest react native version, I got the error UnableToResolveError: Unable to resolve module |
Let me check, I didn't experience any issues on Android or iOS though. |
Oh but I did only test with the version of react-native being used in the example, but that one is pretty outdated. I could update the example too? |
See my latest commit for an updated |
I've now also removed the barcodes directory from the repository, and added JsBarcode as a dependency to use their encoders directly. |
@koenpunt I do think that you are a genius.I'll check the example, if OK, I will publish this package. |
Great 🚀 I will submit some more patches the upcoming time, particularly one for EAN(13) barcodes, since they now do not render when |
I'll appreciate your patches! |
since react-native ships with it's own vector drawing library, why use an external dependency?
This merge request removes
react-native-svg
as a dependency, and implements the rendering using React Native's ART instead.